Skip to content

[DataFrame] Pass read_csv kwargs to _infer_column #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devin-petersohn merged 3 commits into from
Apr 16, 2018
Merged

[DataFrame] Pass read_csv kwargs to _infer_column #1894

devin-petersohn merged 3 commits into from
Apr 16, 2018

Conversation

@p-yang
Copy link
Contributor

@p-yang p-yang commented Apr 13, 2018 •
edited
Loading

What do these changes do?

Passes the kwargs passed to read_csv to _infer_column, as it's important to parse the header row the same way as the other rows.

Related issue number

#1887 Parse file header with same kwargs as caller.

@p-yang p-yang mentioned this pull request Apr 13, 2018
Closed
@AmplabJenkins
Copy link

AmplabJenkins commented Apr 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4857/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4867/
Test FAILed.

@devin-petersohn
Copy link
Member

devin-petersohn commented Apr 13, 2018

Jenkins, retest this please.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4888/
Test FAILed.

@devin-petersohn
Copy link
Member

devin-petersohn commented Apr 14, 2018

Please rebase on master to clear the Jenkins error.

@p-yang p-yang force-pushed the read_csv_delimiter branch from 0d70dd2 to 8bed7a1 Compare April 14, 2018 22:19
@AmplabJenkins
Copy link

AmplabJenkins commented Apr 14, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4904/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 15, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4917/
Test PASSed.

@devin-petersohn devin-petersohn merged commit f505f06 into ray-project:master Apr 16, 2018
royf added a commit to royf/ray that referenced this pull request Apr 22, 2018
@royf
Merge branch 'master' into softq
eb2b27e 
* master:
  Handle interrupts correctly for ASIO synchronous reads and writes. (ray-project#1929)
  [DataFrame] Adding read methods and tests (ray-project#1712)
  Allow task_table_update to fail when tasks are finished. (ray-project#1927)
  [rllib] Contribute DDPG to RLlib (ray-project#1877)
  [xray] Workers blocked in a `ray.get` release their resources (ray-project#1920)
  Raylet task dispatch and throttling worker startup (ray-project#1912)
  [DataFrame] Eval fix (ray-project#1903)
  [tune] Polishing docs (ray-project#1846)
  [tune] [rllib] Automatically determine RLlib resources and add queueing mechanism for autoscaling (ray-project#1848)
  Preemptively push local arguments for actor tasks (ray-project#1901)
  [tune] Allow fetching pinned objects from trainable functions (ray-project#1895)
  Multithreading refactor for ObjectManager. (ray-project#1911)
  Add slice functionality (ray-project#1832)
  [DataFrame] Pass read_csv kwargs to _infer_column (ray-project#1894)
  Addresses missed comments from multichunk object transfer PR. (ray-project#1908)
  Allow numpy arrays to be passed by value into tasks (and inlined in the task spec). (ray-project#1816)
  [xray] Lineage cache requests notifications from the GCS about remote tasks (ray-project#1834)
  Fix UI issue for non-json-serializable task arguments. (ray-project#1892)
  Remove unnecessary calls to .hex() for object IDs. (ray-project#1910)
  Allow multiple raylets to be started on a single machine. (ray-project#1904)

# Conflicts:
#	python/ray/rllib/__init__.py
#	python/ray/rllib/dqn/dqn.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-petersohn devin-petersohn devin-petersohn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@p-yang @AmplabJenkins @devin-petersohn