Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a callback for gcs table lookup failures. #1702

Merged
merged 6 commits into from
Mar 16, 2018
+46 −13
Merged

Add a callback for gcs table lookup failures. #1702

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27cf34d
Add callback to gcs client for table lookup failures.
elibol Mar 12, 2018
5100de2
linting
elibol Mar 13, 2018
07f641c
linting
elibol Mar 13, 2018
c59a065
updates to plasma_manager reflecting changes to gcs callback.
elibol Mar 15, 2018
f1f7aa7
respond with blank string and remove is_nil.
elibol Mar 16, 2018
a099e6b
linting
elibol Mar 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
linting
  • Loading branch information
@elibol
elibol committed Mar 16, 2018
commit a099e6bcc62cb50f25427da095d514c5b9f59715
2 changes: 1 addition & 1 deletion src/plasma/plasma_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,7 +1336,7 @@ void log_object_hash_mismatch_error_result_callback(ObjectID object_id,
log_object_hash_mismatch_error_task_callback(task, user_context);
Task_free(task);
},
[user_context](gcs::AsyncGcsClient *, const TaskID &){
[user_context](gcs::AsyncGcsClient *, const TaskID &) {
// TODO(pcmoritz): Handle failure.
}));
#endif
Expand Down