Add a callback for gcs table lookup failures. #1702
Conversation
|
Test PASSed. |
|
Test PASSed. |
|
Can be merged when the tests pass (the last one is failing at the moment and needs to be fixed). |
|
Test PASSed. |
elibol
force-pushed
the
melih/gcs-failure-callback
branch
from
28703fd to
07f641c
Compare
|
Test PASSed. |
src/ray/gcs/redis_context.h
Outdated
| @@ -21,7 +21,7 @@ namespace gcs { | |||
|
|
|||
| class RedisCallbackManager { | |||
| public: | |||
| using RedisCallback = std::function<void(const std::string &)>; | |||
| using RedisCallback = std::function<void(const std::string &, bool is_nil)>; | |||
There was a problem hiding this comment.
Does it make sense to add this parameter for all RedisCallbacks? I'm a little wary of adding this when it is only used by one of the table operations.
An alternative plan would be to call the failure callback if the response is empty in the Lookup call. Then we can keep the changes completely local to the Lookup operation. The only drawback I see here is that if we won't be able to support an entry that has an empty string as the value, but I think this is probably okay.
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Tests on private travis passed. |
Adds a callback for GCS table lookup failures.