Skip to content

Fix windows test #13811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 120 commits into from
Jan 30, 2021
Merged

Fix windows test #13811

merged 120 commits into from
Jan 30, 2021

Conversation

AmeerHajAli
Copy link
Contributor

@AmeerHajAli AmeerHajAli commented Jan 30, 2021 •
edited
Loading

Fixes:
#13807

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Ameer Haj Ali and others added 30 commits September 24, 2020 00:26
prepare for head node
7248cf9
move command runner interface outside _private
bc43e46
Merge github.com:ray-project/ray
14be0a1
remove space
ab660a8
Eric
1ea0c1f
flake
dad31ae
Merge github.com:ray-project/ray
49bcf56
min_workers in multi node type
16d736d
Merge github.com:ray-project/ray
06911df
fixing edge cases
0d8dddb
eric not idle
fe69ce3
fix target_workers to consider min_workers of node types
35832ed
idle timeout
ca0be53
minor
c9518bd
minor fix
5452d39
test
9e904cd
lint
f9edcbe
eric v2
cb02267
eric 3
5e5d403
min_workers constraint before bin packing
4d44cd8
Merge github.com:ray-project/ray
614abbf
Update resource_demand_scheduler.py
818a63a
@wuisawesome
Revert "Update resource_demand_scheduler.py"
539b29c 
This reverts commit 818a63a.
reducing diff
9a63866
Merge branch 'master' of github.com:AmeerHajAli/ray
7501623
make get_nodes_to_launch return a dict
b4edd21
Merge github.com:ray-project/ray
fc48725
merge
0aef789
weird merge fix
39245a8
auto fill instance types for AWS
c7eb4ad
@AmeerHajAli AmeerHajAli mentioned this pull request Jan 30, 2021
Merged
wuisawesome
wuisawesome approved these changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@wuisawesome wuisawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as long as it passes CI

cc @simon-mo

@AmeerHajAli AmeerHajAli mentioned this pull request Jan 30, 2021
Closed
2 tasks
@AmeerHajAli
Copy link
Contributor Author

@simon-mo , can you please merge?

@AmeerHajAli AmeerHajAli added this to the Serverless Autoscaling milestone Jan 30, 2021
@wuisawesome wuisawesome added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jan 30, 2021
@simon-mo simon-mo merged commit 660857f into ray-project:master Jan 30, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@fishbone
Fix windows test (ray-project#13811)
33c190b
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@fishbone
Revert "Fix windows test (ray-project#13811)"
41b9970 
This reverts commit 33c190b.
@DmitriGekhtman DmitriGekhtman mentioned this pull request Feb 28, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuisawesome wuisawesome wuisawesome approved these changes

@simon-mo simon-mo Awaiting requested review from simon-mo

Assignees

@wuisawesome wuisawesome

@simon-mo simon-mo

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
Infra Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@AmeerHajAli @wuisawesome @simon-mo @ericl @DmitriGekhtman