Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[autoscaler] Better validation for min_workers and max_workers " #13807

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented Jan 29, 2021

Reverts #13779 consistently failed on windows


================================== FAILURES ===================================
________ AutoscalingConfigTest.testValidateDefaultConfigMinMaxWorkers _________

self = <com_github_ray_project_ray.python.ray.tests.test_autoscaler_yaml.AutoscalingConfigTest testMethod=testValidateDefaultConfigMinMaxWorkers>

    def testValidateDefaultConfigMinMaxWorkers(self):
        aws_config_path = os.path.join(
            RAY_PATH, "autoscaler/aws/example-multi-node-type.yaml")
>       with open(aws_config_path) as f:
E       OSError: [Errno 22] Invalid argument: '\\\\?\\C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\Bazel.runfiles_6y4y9g7o\\runfiles\\com_github_ray_project_ray\\python\\ray\\autoscaler/aws/example-multi-node-type.yaml'

\\?\C:\Users\RUNNER~1\AppData\Local\Temp\Bazel.runfiles_6y4y9g7o\runfiles\com_github_ray_project_ray\python\ray\tests\test_autoscaler_yaml.py:51: OSError

Copy link
Contributor

@wuisawesome wuisawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon-mo simon-mo merged commit 5080802 into master Jan 29, 2021
@simon-mo simon-mo deleted the revert-13779-yaml branch January 29, 2021 23:43
@AmeerHajAli
Copy link
Contributor

I fixed here:
#13811

@AmeerHajAli AmeerHajAli mentioned this pull request Jan 30, 2021
6 tasks
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants