Skip to content

Conversation

rgabs
Copy link
Contributor

@rgabs rgabs commented Dec 1, 2017

No description provided.

@marudy
Copy link
Collaborator

marudy commented Aug 16, 2018

Heads up! If you merge PR #10, you need to rename the event removed here, before proceeding with merge!

@marudy
Copy link
Collaborator

marudy commented Oct 10, 2018

Hey @rgabs and thanks for the PR. I would like to merge it, but can you first change the event name from the deprecated to the new one? Because we also merged this PR? that changes the event name.

@rgabs
Copy link
Contributor Author

rgabs commented Oct 11, 2018

Hey @marudy
I have made the required changes.

Now use the force to merge the PR, you must. ⚡️🌟

Copy link
Collaborator

@marudy marudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@marudy marudy merged commit 2a25caa into rauchy:master Oct 11, 2018
@marudy
Copy link
Collaborator

marudy commented Oct 11, 2018

@rgabs force is my friend hehe ⚔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants