Skip to content

Conversation

AbhishekBiswal
Copy link
Contributor

No description provided.

@rauchy
Copy link
Owner

rauchy commented Apr 17, 2018

Thanks for the patch!

Could you provide some description and references to what this actually solves?

I believe that these changes will break for most users unless you add dependency restrictions (on react or react-native I suppose)

@AbhishekBiswal
Copy link
Contributor Author

@rauchy The current version of the module throws warnings (multiple, annoying) after upgrading (or using version >=) to React Native 0.48.0. To notify users who are using the older RN version, you can mention the exact version of the module to be used in the README. 💯

@marudy
Copy link
Collaborator

marudy commented Oct 9, 2018

Hi @AbhishekBiswal,

and thanks for your PR. It's time to merge it but before we do so, can you also change reach to type for the argument of connect function? That should be consistent as well.

If you don't have the time, just say it and I will do it for you.

Thanks mate,
Tasos

@AbhishekBiswal
Copy link
Contributor Author

Hey @marudy Done, can you check and merge? Thanks!

Copy link
Collaborator

@marudy marudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @AbhishekBiswal, will merge now :)

Thanks again for the PR, mate.

@marudy marudy merged commit 326566d into rauchy:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants