Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tf dpr finalize #2

Merged
merged 6 commits into from
Nov 11, 2020
Merged

Tf dpr finalize #2

merged 6 commits into from
Nov 11, 2020

Commits on Nov 11, 2020

  1. del config_class, load_tf_weights 

    They shoud be 'pytorch only'
    @ratthachat
    ratthachat authored Nov 11, 2020
    Configuration menu
    Copy the full SHA
    ccfd0f4 View commit details
    Browse the repository at this point in the history

  2. add config_class back 

    after removing it, test failed ... so totally only removing "use_tf_weights = None" on Lysandre suggestion
    @ratthachat
    ratthachat authored Nov 11, 2020
    Configuration menu
    Copy the full SHA
    9ab698a View commit details
    Browse the repository at this point in the history

  3. newline after .. note::

    @ratthachat
    ratthachat authored Nov 11, 2020
    Configuration menu
    Copy the full SHA
    a619f6b View commit details
    Browse the repository at this point in the history

  4. import tf, np (Necessary for ModelIntegrationTest)

    @ratthachat
    ratthachat authored Nov 11, 2020
    Configuration menu
    Copy the full SHA
    7525403 View commit details
    Browse the repository at this point in the history

  5. slow_test from_pretrained with from_pt=True 

    At the moment we don't have TF weights (since we don't have official official TF model)
Previously, I did not run slow test, so I missed this bug
    @ratthachat
    ratthachat authored Nov 11, 2020
    Configuration menu
    Copy the full SHA
    4c2d085 View commit details
    Browse the repository at this point in the history

  6. Add simple TFDPRModelIntegrationTest 

    Note that this is just a test that TF and Pytorch gives approx. the same output.
However, I could not test with the official DPR repo's output yet
    @ratthachat
    ratthachat authored Nov 11, 2020
    Configuration menu
    Copy the full SHA
    e029755 View commit details
    Browse the repository at this point in the history