Tf dpr finalize #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They shoud be 'pytorch only'
after removing it, test failed ... so totally only removing "use_tf_weights = None" on Lysandre suggestion
At the moment we don't have TF weights (since we don't have official official TF model) Previously, I did not run slow test, so I missed this bug
Note that this is just a test that TF and Pytorch gives approx. the same output. However, I could not test with the official DPR repo's output yet
ratthachat
pushed a commit
that referenced
this pull request
Dec 2, 2020
* restore skip * Revert "Remove deprecated `evalutate_during_training` (huggingface#8852)" This reverts commit 5530299. * check that pipeline.git.base_revision is defined before proceeding * Revert "Revert "Remove deprecated `evalutate_during_training` (huggingface#8852)"" This reverts commit dfec84d. * check that pipeline.git.base_revision is defined before proceeding * doc only * doc + code * restore * restore * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Address Lysandre, Sylvain and (some of) Patrick's comments