Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL and build warning fixes #192

Merged
merged 2 commits into from
Feb 5, 2025
Merged

CodeQL and build warning fixes #192

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c5c015
CodeQL fixes
henrygab Dec 31, 2024
c89d7c9
Merge branch 'develop' into CodeQL
henrygab Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'develop' into CodeQL
  • Loading branch information
@henrygab
henrygab authored Jan 8, 2025
commit c89d7c903b39515b7804bdc652321fca2d6daa62
5 changes: 3 additions & 2 deletions bintool/metadata.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,9 @@ struct partition_table_item : public single_byte_size_item {
new_p.flags = permissions_flags & (~PICOBIN_PARTITION_PERMISSIONS_BITS);

if (new_p.flags & PICOBIN_PARTITION_FLAGS_HAS_ID_BITS) {
new_p.id = (uint64_t)data[i] | ((uint64_t)data[i+1] << 32);
i += 2;
uint32_t low = data[i++];
uint32_t high = data[i++];
new_p.id = (uint64_t)low | ((uint64_t)high << 32);
}

uint8_t num_extra_families = (new_p.flags & PICOBIN_PARTITION_FLAGS_ACCEPTS_NUM_EXTRA_FAMILIES_BITS) >> PICOBIN_PARTITION_FLAGS_ACCEPTS_NUM_EXTRA_FAMILIES_LSB;
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.