CodeQL and build warning fixes #192
Merged
+23
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes various errors automaticallly detected by CodeQL. * Too few arguments to formatting function * Wrong type of arguments to formatting function * `size_t` uses format specifier `z` * `uint32_t` uses format specifier `PRIx32` Also fix various build warnings. * Fix: comparison of integer expressions of different signedness [-Wsign-compare] * Fix: operation on 'i' may be undefined [-Wsequence-point] * Fix: 'expected_redundancy' may be used uninitialized [-Wmaybe-uninitialized]
|
Can you target this PR at the |
lurch
reviewed
Jan 7, 2025
@will-v-pi -- Done ... Could you please let me know if there's something more needed? Thank you. |
|
@will-v-pi -- Would you be able to help set expectations on the timeline? Do these typically take a few days, a week, a few weeks, a month, many months? If they tend to take a while, do you rely on submitted to rebase or merge? Thanks for helping me, to avoid bothering you! |
|
The timeline could be a few weeks to a few months, depending on how busy we are, and how useful a feature the PR is adding. We'd rely on you to rebase if any merge conflicts arise. |
will-v-pi
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled CodeQL in the buspirate firmware project ... an awesome tool built around RP2040 and RP2350. CodeQL automatically caught a number of errors in
picotool.This resolves those errors (and a few more besides).
size_tuses format specifierzuint32_tuses format specifierPRIx32* Fix: operation on 'i' may be undefined [-Wsequence-point]