-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chainlit bonus material fixes #361
Conversation
Please double-check if this works fine for you too 🙂 I think it would be good to add a welcome message for the user to see that the chatbot is working before typing, currently there is none. What do you also think about adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the PR! There was only a minor thing where the device movement can be simplified (i.e., the cloning and detaching shouldn't be necessary)
Thanks for suggesting, but I would just stay with simplicity here.
This is a good suggestion, but it's already handled in the |
Okay, I see. I think it would be helpful to add this info as a code comment as this not directly obvious from the code, and it would be on par with your written code that uses |
Re: The warning you are getting without cloning and detaching Oh interesting, I am not getting the warning. Maybe it's an older PyTorch version or a Windows thing? |
I ran the code both on Linux as well as Windows. I think this has been the fix suggested by the error message, so that's why I added it to the code. Just tested your changes: without
LGTM 🙂 |
.files
folder from chainlit to.gitignore
.files
directory is used by Chainlit to store temporary files during runtime, which should not be included in version control