Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thrust when exported now automatically calls thrust_create_target #467

Merged
merged 14 commits into from
Oct 9, 2023
Merged

Thrust when exported now automatically calls thrust_create_target #467

merged 14 commits into from
Oct 9, 2023

Commits on Sep 28, 2023

  1. Thrust when exporte now automatically calls thrust_create_target 

    Instead of having each consuming project inject a code block into
the `project-config.cmake` we instead have rapids-cmake call
`thrust_create_target` right after `find_package(Thrust)`,
only when thrust was found.

This fixes two existing issues:
  1. It removes the need for `rapids_cpm_thrust` to remove the
  the custom Thrust target from the global target set. Now that
  target will exist when rapids-cmake tries to promote it to global
  2. It removes issues when multiple calls to `find_package(thrust)`
  occur before any calls to `thrust_create_target`. This creates
  some vexing issues when the thrust find calls resolve to different
  major versions of thrust
    @robertmaynard
    robertmaynard committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    21db3d8 View commit details
    Browse the repository at this point in the history

  2. Expand thrust cpm docs

    @robertmaynard
    robertmaynard committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2c9bb4a View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Update testing/cpm/cpm_thrust-verify-post-find-code/CMakeLists.txt 

    Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
    @robertmaynard @vyasr
    robertmaynard and vyasr authored Oct 2, 2023
    Configuration menu
    Copy the full SHA
    f22abd4 View commit details
    Browse the repository at this point in the history

  2. Revise export_package-build-post-find-code.cmake based on PR feedback

    @robertmaynard
    robertmaynard committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    0770334 View commit details
    Browse the repository at this point in the history

  3. Make spacing around function args consistent

    @robertmaynard
    robertmaynard committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    c83904a View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Refactor rapids_export_post_find and rapids_export_find_package_root 

    These commands now offer a syntax that allows termination
based on no export set being given, or a external condition
variable.
    @robertmaynard
    robertmaynard committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    ac69df5 View commit details
    Browse the repository at this point in the history

  2. Update cmake-format

    @robertmaynard
    robertmaynard committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    d488514 View commit details
    Browse the repository at this point in the history

  3. Update rapids-cmake/export/detail/post_find_package_code.cmake 

    Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
    @robertmaynard @vyasr
    robertmaynard and vyasr authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    d61b05a View commit details
    Browse the repository at this point in the history

  4. Change API as suggested in code review

    @robertmaynard
    robertmaynard committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    5a67645 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Add deprecation message to export functions

    @robertmaynard
    robertmaynard committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    cb2937c View commit details
    Browse the repository at this point in the history

  2. Correct style issues

    @robertmaynard
    robertmaynard committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    3f179d0 View commit details
    Browse the repository at this point in the history

  3. Correct style issues

    @robertmaynard
    robertmaynard committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    9f72b7b View commit details
    Browse the repository at this point in the history

  4. Ensure deprecation tests produce error messages

    @robertmaynard
    robertmaynard committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    a1a9831 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Merge branch 'branch-23.12' into fea/export-dependencies-auto-call-th… 

    …rust_create_target
    @robertmaynard
    robertmaynard authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    782299e View commit details
    Browse the repository at this point in the history