Thrust when exported now automatically calls thrust_create_target
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having each consuming project inject a code block into the `project-config.cmake` we instead have rapids-cmake call `thrust_create_target` right after `find_package(Thrust)`, only when thrust was found. This fixes two existing issues: 1. It removes the need for `rapids_cpm_thrust` to remove the the custom Thrust target from the global target set. Now that target will exist when rapids-cmake tries to promote it to global 2. It removes issues when multiple calls to `find_package(thrust)` occur before any calls to `thrust_create_target`. This creates some vexing issues when the thrust find calls resolve to different major versions of thrust
robertmaynard
added
feature request
vyasr
requested changes
Oct 2, 2023
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
These commands now offer a syntax that allows termination based on no export set being given, or a external condition variable.
robertmaynard
force-pushed
the
fea/export-dependencies-auto-call-thrust_create_target
branch
from
e7ff0d5
to
ac69df5
Compare
vyasr
requested changes
Oct 3, 2023
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
…rust_create_target
vyasr
approved these changes
Oct 9, 2023
|
/merge |
robertmaynard
deleted the
fea/export-dependencies-auto-call-thrust_create_target
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of having each consuming project inject a code block into the
project-config.cmakewe instead have rapids-cmake callthrust_create_targetright afterfind_package(Thrust), only when thrust was found.This fixes two existing issues:
rapids_cpm_thrustto remove the the custom Thrust target from the global target set. Now that target will exist when rapids-cmake tries to promote it to globalfind_package(thrust)occur before any calls tothrust_create_target. This creates some vexing issues when the thrust find calls resolve to different major versions of thrustChecklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))