-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support scikit-build-core #433
Support scikit-build-core #433
Conversation
fc8649f
to
6ecb9b0
Compare
6ecb9b0
to
b3f714e
Compare
fb2d226
to
418686d
Compare
418686d
to
9290ffd
Compare
This reverts commit b91ddce.
4854b81
to
af0531e
Compare
…ey don't overlap and fix some minor issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are cython and cython-core meant to be used separately? Do we need to document that or raise an error if a project uses both? Can projects mix cython and cython-core in dependencies, like rmm using cython-core while cudf uses cython?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing documentation and cmake-format updates
I added docs. The new functions are identical to the old ones, just included differently ( |
/merge |
Description
This PR adds a new cython-core module of rapids-cmake that can be used with scikit-build-core.
cython-core
is designed as a drop-in replacement forcython
, allowing consumers to simply change theinclude(cython)
toinclude(cython-core)
and have things generally work as expected when switching Python build backends.Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)