Skip to content

Commit

Permalink
Stop specifying output and add explicit dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
vyasr committed Dec 6, 2023
1 parent 7223ed7 commit 4854b81
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rapids-cmake/cython-core/create_modules.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,11 @@ function(rapids_cython_create_modules)

# Generate C++ from Cython and create a library for the resulting extension module to compile.
cython(SOURCE_FILES "${CMAKE_CURRENT_SOURCE_DIR}/${cython_filename}" TARGET_LANGUAGE
${_language_flag} LANGUAGE_LEVEL 3 CYTHON_ARGS
"--directive ${_directives} --output-file ${CMAKE_CURRENT_BINARY_DIR}/${cpp_filename}")
${_language_flag} LANGUAGE_LEVEL 3 CYTHON_ARGS "--directive ${_directives}")

python_add_library(${cython_module} MODULE "${CMAKE_CURRENT_BINARY_DIR}/${cpp_filename}"
WITH_SOABI)
add_dependencies(${cython_module} ${cython_module}_transpiled)

# The final library name must match the original filename and must ignore the prefix.
set_target_properties(${cython_module} PROPERTIES LIBRARY_OUTPUT_NAME ${cython_module_filename})
Expand Down

0 comments on commit 4854b81

Please sign in to comment.