-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs build job #347
Merged
Merged
Add docs build job #347
Changes from 20 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
cc3111c
initial draft
AyodeAwe 1bccb03
update build_docs.sh
AyodeAwe daff4ca
chmod
AyodeAwe 000a387
update build_docs.sh
AyodeAwe 5592c0b
update deps
AyodeAwe d324f22
Update dependencies.yaml
AyodeAwe 425ed04
Update ci/build_docs.sh
AyodeAwe 9ed99dc
Update ci/build_docs.sh
AyodeAwe f66dbe6
Update ci/build_docs.sh
AyodeAwe d7e3f73
Update ci/build_docs.sh
AyodeAwe 5ba5b82
Update ci/build_docs.sh
AyodeAwe e9a6bd9
Update ci/build_docs.sh
AyodeAwe add43fd
fix lang
AyodeAwe 3bbeb38
Merge branch 'add_docs_build' of github.com:AyodeAwe/rapids-cmake int…
AyodeAwe 129d60c
Merge branch 'branch-23.02' into add_docs_build
AyodeAwe 12c7817
copyright fix
AyodeAwe 092af00
Merge branch 'add_docs_build' of github.com:AyodeAwe/rapids-cmake int…
AyodeAwe e48a809
fixes
AyodeAwe 493920b
update conf.py
AyodeAwe eac6a77
Merge branch 'branch-23.04' into add_docs_build
AyodeAwe 108bde6
fix typo
AyodeAwe 749d91c
Merge branch 'add_docs_build' of github.com:AyodeAwe/rapids-cmake int…
AyodeAwe 9ff03be
rm -W flag
AyodeAwe c7ed678
fix warnings
AyodeAwe 82ffacd
docs_build -> docs
AyodeAwe a7b6d05
Merge branch 'branch-23.04' into add_docs_build
AyodeAwe a53a7b3
Update .github/workflows/build.yaml
AyodeAwe 773ac64
Update .github/workflows/pr.yaml
AyodeAwe 3a8a0a6
Update dependencies.yaml
AyodeAwe 2bf6416
Update docs/conf.py
AyodeAwe 76d82d1
Update rapids-cmake/cython/create_modules.cmake
AyodeAwe e96a260
Update rapids-cmake/cython/add_rpath_entries.cmake
AyodeAwe 5978af4
fix checks
AyodeAwe c392729
Update docs/conf.py
ajschmidt8 7c25f5b
Merge branch 'branch-23.04' into add_docs_build
ajschmidt8 7e59bcb
review fixes
AyodeAwe 76ce4ed
rm os import
AyodeAwe 8164582
Apply suggestions from code review
ajschmidt8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
#!/bin/bash | ||
# Copyright (c) 2023, NVIDIA CORPORATION. | ||
|
||
set -euo pipefail | ||
|
||
rapids-logger "Create test conda environment" | ||
. /opt/conda/etc/profile.d/conda.sh | ||
|
||
rapids-dependency-file-generator \ | ||
--output conda \ | ||
--file_key docs \ | ||
--matrix "cuda=${RAPIDS_CUDA_VERSION%.*};arch=$(arch);py=${RAPIDS_PY_VERSION}" | tee env.yaml | ||
|
||
rapids-mamba-retry env create --force -f env.yaml -n docs | ||
conda activate docs | ||
|
||
rapids-print-env | ||
|
||
VERSION_NUMBER=$(rapids-get-rapids-version-from-git) | ||
|
||
rapids-logger "Build Sphinx docs" | ||
pushd docs | ||
sphinx-build -b dirhtml . _html -W | ||
sphinx-build -b text . _text -W | ||
popd | ||
|
||
|
||
if [[ ${RAPIDS_BUILD_TYPE} == "branch" ]]; then | ||
aws s3 sync --delete docs/_html "s3://rapidsai-docs/rapids-cmake/${VERSION_NUMBER}/html" | ||
aws s3 sync --delete docs/_text "s3://rapidsai-docs/rapids-cmake/${VERSION_NUMBER}/txt" | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just discovered this problem that we'll need to update in all of the docs build PRs that have already been merged.
We need to change this conditional so that this job doesn't run as part of the nightly builds.
The docs builds aren't intended to run as part of the nightly jobs, so they're currently breaking the nightly builds (see cuml nightly job here for reference).
We can update this conditional as shown here to:
branch
assertionpush
events (as opposed toworkflow_dispatch
events which trigger the nightlies).After this PR is merged, we can test that this conditional works correctly and then roll out the fix to other repositories.
cc: @AjayThorve