Add docs build job #347
Merged
Add docs build job #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyodeAwe
added
improvement
AyodeAwe
force-pushed
the
add_docs_build
branch
from
6e3b7a1
to
cc3111c
Compare
ajschmidt8
reviewed
Jan 25, 2023
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
ajschmidt8
reviewed
Feb 1, 2023
ajschmidt8
reviewed
Feb 6, 2023
robertmaynard
approved these changes
Feb 10, 2023
bdice
previously requested changes
Feb 10, 2023
update docs step to use a branch-23.04 Co-authored-by: Bradley Dice <bdice@bradleydice.com>
update docs step to use a branch-23.04 Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
ajschmidt8
reviewed
Feb 14, 2023
ajschmidt8
requested changes
Feb 16, 2023
ajschmidt8
reviewed
Feb 17, 2023
.github/workflows/build.yaml
Outdated
| @@ -45,3 +45,13 @@ jobs: | |||
| branch: ${{ inputs.branch }} | |||
| date: ${{ inputs.date }} | |||
| sha: ${{ inputs.sha }} | |||
| docs-build: | |||
| if: ${{ startsWith(github.ref, 'refs/heads/branch-') }} | |||
There was a problem hiding this comment.
Suggested change
| if: ${{ startsWith(github.ref, 'refs/heads/branch-') }} | |
| if: github.ref_type == 'branch' && github.event_name == 'push' |
I just discovered this problem that we'll need to update in all of the docs build PRs that have already been merged.
We need to change this conditional so that this job doesn't run as part of the nightly builds.
The docs builds aren't intended to run as part of the nightly jobs, so they're currently breaking the nightly builds (see cuml nightly job here for reference).
We can update this conditional as shown here to:
- simplify the
branchassertion - ensure that it only runs on
pushevents (as opposed toworkflow_dispatchevents which trigger the nightlies).
After this PR is merged, we can test that this conditional works correctly and then roll out the fix to other repositories.
cc: @AjayThorve
ajschmidt8
reviewed
Feb 17, 2023
ajschmidt8
approved these changes
Feb 17, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a
docs_buildprocess to the PR and Build workflows for this repository. The generated docs are synced to s3 for only the build workflows.