Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up imports for cudf changes #1383

Merged
merged 1 commit into from
May 17, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 13, 2024

Description

This PR will be necessary for cuspatial to build successfully once rapidsai/cudf#15740 is merged.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 13, 2024
@vyasr vyasr self-assigned this May 13, 2024
@github-actions github-actions bot added the Python Related to Python code label May 13, 2024
@trxcllnt trxcllnt marked this pull request as ready for review May 14, 2024 22:16
@trxcllnt trxcllnt requested a review from a team as a code owner May 14, 2024 22:16
@trxcllnt trxcllnt requested review from thomcom and isVoid May 14, 2024 22:16
@vyasr vyasr requested a review from a team as a code owner May 14, 2024 23:20
@github-actions github-actions bot added the conda Related to conda and conda configuration label May 14, 2024
@vyasr vyasr added the 5 - DO NOT MERGE Hold off on merging; see PR for details label May 14, 2024
@vyasr
Copy link
Contributor Author

vyasr commented May 14, 2024

Temporarily blocking merge here since the last commit is a patch and the real fix should be made upstream in cudf, see rapidsai/cudf#15755

@vyasr vyasr force-pushed the chore/cudf_pxd_migration branch from 2039857 to fae77d7 Compare May 15, 2024 16:24
@vyasr vyasr removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label May 15, 2024
@github-actions github-actions bot removed the conda Related to conda and conda configuration label May 15, 2024
@AyodeAwe
Copy link
Contributor

admin merging on author request

@AyodeAwe AyodeAwe merged commit 61b8cc1 into rapidsai:branch-24.06 May 17, 2024
119 of 134 checks passed
@vyasr vyasr deleted the chore/cudf_pxd_migration branch May 17, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants