Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arrow versioning logic #15755

Merged
merged 4 commits into from
May 15, 2024
Merged

Fix arrow versioning logic #15755

merged 4 commits into from
May 15, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 14, 2024

Description

Resolves #15754

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels May 14, 2024
@vyasr vyasr self-assigned this May 14, 2024
@vyasr vyasr requested review from a team as code owners May 14, 2024 23:36
@vyasr vyasr requested a review from msarahan May 14, 2024 23:36
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue labels May 14, 2024
@vyasr vyasr mentioned this pull request May 14, 2024
Merged
3 tasks
bdice
bdice approved these changes May 14, 2024
View reviewed changes
cpp/cmake/thirdparty/get_arrow.cmake Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented May 14, 2024

An open question, should we update to 16.1 while we're here? @galipremsagar WDYT?

@bdice
Copy link
Contributor

bdice commented May 14, 2024

An open question, should we update to 16.1 while we're here? @galipremsagar WDYT?

I think conda-forge hasn’t migrated yet. Let’s wait for conda-forge to move first. https://conda-forge.org/status/migration/libarrow16

galipremsagar
galipremsagar approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vyasr ! Yes, I agree with @bdice, let's punt upgrading to 16.1 once conda packages are out.

@galipremsagar
Copy link
Contributor

/merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 15, 2024
@rapids-bot rapids-bot bot merged commit 0fea3ed into rapidsai:branch-24.06 May 15, 2024
70 checks passed
@vyasr vyasr deleted the fix/arrow_version_logic branch May 15, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees

@vyasr vyasr

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Stop allowing floating arrow along minor versions
3 participants
@vyasr @bdice @galipremsagar