This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 131
fix filtering.resample output for even values of num parameter #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[RELEASE] cusignal v0.13
[RELEASE] cusignal v0.14
[HOTFIX] Fix missing six package on cusignal import [skip-ci-changelog]
[skip ci] Update master references for main branch
[RELEASE] cusignal v0.16
[RELEASE] cusignal v0.17
[RELEASE] cusignal v0.18
[RELEASE] cusignal v0.19
REL Fix `21.06` Release Changelog
[RELEASE] cusignal v21.08
[RELEASE] cusignal v21.10
[RELEASE] cusignal v21.12
[RELEASE] cusignal v22.02
[RELEASE] cusignal v22.04
[RELEASE] cusignal v22.06
[RELEASE] cusignal v22.08
[HOTFIX] `22.10` `numpy` hotfix
Can one of the admins verify this patch? Admins can comment |
1 similar comment
Can one of the admins verify this patch? Admins can comment |
ok to test |
awthomp
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Nov 21, 2022
Hey @mattkinsey ! Thanks for the PR; looks great! I had to change the base branch you were merging into (branch-22.12 rather than main) and fix some minor merge conflicts, but otherwise looks good. We'll get this merged ASAP. Thanks for your contributions, and Happy Thanksgiving! |
awthomp
approved these changes
Nov 21, 2022
rerun tests |
@gpucibot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just fixes the handling of the nyquest frequency bins when resampling using the FFT method (
filtering.resample
).Without enforcing the fourier space be hermitian symmetric like this, the resampled output had a few undesirable properties:
resample(resample(y, <larger size than y>), <original y size>) != y
scipy.signal.resample
. The max error was around 1e-2 in my application.Thanks