Updating Clang Version to 11.0.0 #6695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codereport
added
2 - In Progress
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #6695 +/- ##
===============================================
Coverage ? 10.64%
===============================================
Files ? 109
Lines ? 18654
Branches ? 0
===============================================
Hits ? 1985
Misses ? 16669
Partials ? 0 Continue to review full report at Codecov.
|
harrism
reviewed
Nov 8, 2020
ajschmidt8
approved these changes
Nov 9, 2020
|
@codereport should we push this to 0.18? |
Yep, let's do that. |
codereport
changed the title
|
@codereport maybe we can get to this in 0.19. |
Yea sorry, this has been on the back burner. Will be one of my focuses in .19 |
dillon-cullinan
approved these changes
Jun 28, 2021
codereport
added
5 - Ready to Merge
|
@codereport we're missing a really great opportunity to title this PR “Turn Clang up to 11” |
|
rerun tests |
1 similar comment
|
rerun tests |
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Jul 6, 2021
Follow up PR to: rapidsai/cudf#6695. Performing the same changes but for `rapidsai/rmm` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Rong Ou (https://github.com/rongou) - Christopher Harris (https://github.com/cwharris) - Dillon Cullinan (https://github.com/dillon-cullinan) URL: #814
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Jul 6, 2021
Follow up PR to: rapidsai/cudf#6695. Performing the same changes but for `rapidsai/cuspatial` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Dillon Cullinan (https://github.com/dillon-cullinan) - H. Thomson Comer (https://github.com/thomcom) URL: #426
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Jul 7, 2021
Follow up PR to: rapidsai/cudf#6695. Performing the same changes but for `rapidsai/cugraph` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Dillon Cullinan (https://github.com/dillon-cullinan) - Chuck Hastings (https://github.com/ChuckHastings) URL: #1688
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jul 9, 2021
Follow up PR to: rapidsai/cudf#6695. Performing the same changes but for `rapidsai/cuml` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - William Hicks (https://github.com/wphicks) - AJ Schmidt (https://github.com/ajschmidt8) - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) URL: #4029
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Follow up PR to: rapidsai/cudf#6695. Performing the same changes but for `rapidsai/cuml` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - William Hicks (https://github.com/wphicks) - AJ Schmidt (https://github.com/ajschmidt8) - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves: #5187
PR description copied from: rapidsai/cuml#3121
Depends on: rapidsai/integration#304
This PR will upgrade the clang version required to 11.0.0 in order to enable us with running clang-tidy on .cu files, while running on cuda v11. See rapidsai/raft#88 for more details.
CI will not pass as the underlying conda-env still uses 8.0.1. Once we have the rapids-build-env meta package updated, this should pass.
Fixes from Clang 8.0.1 to Clang 11.0.0 (that are observed in delta)
To do list: