Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Clang Version to 11.0.0 #426

Merged
merged 8 commits into from
Jul 6, 2021
Merged

Updating Clang Version to 11.0.0 #426

merged 8 commits into from
Jul 6, 2021

Conversation

codereport
Copy link
Contributor

@codereport codereport commented Jun 26, 2021 •
edited
Loading

Follow up PR to: rapidsai/cudf#6695. Performing the same changes but for rapidsai/cuspatial

Depends on: rapidsai/integration#304

@codereport codereport requested review from a team as code owners June 26, 2021 00:37
@github-actions github-actions bot added conda Related to conda and conda configuration libcuspatial Relates to the cuSpatial C++ library gpuCI Related to Continuous Integration / Automation labels Jun 26, 2021
@codereport codereport mentioned this pull request Jun 28, 2021
Merged
dillon-cullinan
dillon-cullinan suggested changes Jun 28, 2021
View reviewed changes
ci/checks/style.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the gpuCI Related to Continuous Integration / Automation label Jun 28, 2021
thomcom
thomcom requested changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@thomcom thomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected that the clang version fails in gpuCI/cuspatial/check/style now? Glad to approve when tests pass.

@codereport
Copy link
Contributor Author

Is it expected that the clang version fails in gpuCI/cuspatial/check/style now? Glad to approve when tests pass.

Yes, once rapidsai/integration#304 is merged, I will retrigger CI for all the Clang11 format PRs and they will light up green (and once missing labels have been added)

@codereport
Copy link
Contributor Author

rerun tests

1 similar comment
@codereport
Copy link
Contributor Author

rerun tests

@thomcom thomcom added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 6, 2021
@codereport codereport requested a review from thomcom July 6, 2021 19:36
@thomcom
Copy link
Contributor

thomcom commented Jul 6, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8c31c2c into rapidsai:branch-21.08 Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@dillon-cullinan dillon-cullinan dillon-cullinan approved these changes

@zhangjianting zhangjianting Awaiting requested review from zhangjianting

Assignees
No one assigned
Labels
conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codereport @thomcom @dillon-cullinan