Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add telemetry setup to test #16924

Merged
merged 6 commits into from
Nov 15, 2024
Merged

add telemetry setup to test #16924

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26463f1
telemetry setup
msarahan Oct 2, 2024
a5f8948
revert conda build command; add continue-on-error to initial telemetr…
msarahan Nov 14, 2024
d9ff0b9
use simpler cert concat
msarahan Nov 14, 2024
d80d4db
Minimize changes to needs
msarahan Nov 15, 2024
b93b626
move pr-builder to top of jobs
msarahan Nov 15, 2024
47dac44
Merge branch 'add-telemetry' of github.com:msarahan/cudf into add-tel…
msarahan Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ concurrency:
cancel-in-progress: true

jobs:
telemetry-setup:
msarahan marked this conversation as resolved.
Show resolved Hide resolved
continue-on-error: true
runs-on: ubuntu-latest
env:
OTEL_SERVICE_NAME: 'pr-cudf'
steps:
- name: Telemetry setup
uses: rapidsai/shared-actions/telemetry-dispatch-stash-base-env-vars@main
pr-builder:
needs:
- changed-files
Expand Down Expand Up @@ -37,13 +45,15 @@ jobs:
- unit-tests-cudf-pandas
- pandas-tests
- pandas-tests-diff
- telemetry-setup
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@branch-24.12
if: always()
with:
needs: ${{ toJSON(needs) }}
changed-files:
secrets: inherit
needs: telemetry-setup
uses: rapidsai/shared-workflows/.github/workflows/changed-files.yaml@branch-24.12
with:
files_yaml: |
Expand Down Expand Up @@ -91,9 +101,11 @@ jobs:
- '!notebooks/**'
checks:
secrets: inherit
needs: telemetry-setup
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@branch-24.12
with:
enable_check_generated_files: false
ignored_pr_jobs: "telemetry-summarize"
conda-cpp-build:
needs: checks
secrets: inherit
Expand Down Expand Up @@ -260,6 +272,7 @@ jobs:
devcontainer:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@branch-24.12
needs: telemetry-setup
with:
arch: '["amd64"]'
cuda: '["12.5"]'
Expand Down Expand Up @@ -298,3 +311,18 @@ jobs:
node_type: cpu4
build_type: pull-request
run_script: "ci/cudf_pandas_scripts/pandas-tests/diff.sh"

telemetry-summarize:
runs-on: ubuntu-latest
needs: pr-builder
if: always()
continue-on-error: true
steps:
- name: Load stashed telemetry env vars
uses: rapidsai/shared-actions/telemetry-dispatch-load-base-env-vars@main
with:
load_service_name: true
- name: Telemetry summarize
uses: rapidsai/shared-actions/telemetry-dispatch-write-summary@main
with:
cert_concat: "${{ secrets.OTEL_EXPORTER_OTLP_CA_CERTIFICATE }};${{ secrets.OTEL_EXPORTER_OTLP_CLIENT_CERTIFICATE }};${{ secrets.OTEL_EXPORTER_OTLP_CLIENT_KEY }}"
Loading