Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add telemetry setup to test #16924

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Conversation

msarahan
Copy link
Contributor

Description

This is a prototype implementation of https://github.com/rapidsai/build-infra/issues/139

The work that this builds on:

  • Add otel wrapper gha-tools#118, which adds a shell wrapper that automatically creates spans for the commands that it wraps. It also uses the opentelemetry-instrument command to set up monkeypatching for supported Python libraries, if the command is python-based
  • https://github.com/rapidsai/shared-workflows/tree/add-telemetry, which installs the gha-tools work from above and sets necessary environment variables. This is only done for the conda-cpp-build.yaml shared workflow at the time of submitting this PR.

The goal of this PR is to observe telemetry data sent from a GitHub Actions build triggered by this PR as a proof of concept. Once it all works, the remaining work is:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@msarahan msarahan added feature request New feature or request non-breaking Non-breaking change ci Needs build-infra Requires input from the build infrastructure team labels Sep 26, 2024
@msarahan msarahan force-pushed the add-telemetry branch 2 times, most recently from 2f90060 to a540ab4 Compare October 2, 2024 22:44
Copy link

copy-pr-bot bot commented Oct 2, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Oct 2, 2024
@msarahan msarahan changed the base branch from branch-24.10 to branch-24.12 October 2, 2024 22:44
@msarahan
Copy link
Contributor Author

msarahan commented Oct 2, 2024

/ok to test

@github-actions github-actions bot removed libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Oct 3, 2024
@msarahan msarahan marked this pull request as ready for review November 14, 2024 00:34
@msarahan msarahan requested a review from a team as a code owner November 14, 2024 00:34
@msarahan msarahan requested a review from bdice November 14, 2024 00:34
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small request, then this should be good to go.

.github/workflows/pr.yaml Outdated Show resolved Hide resolved
@msarahan
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8664fad into rapidsai:branch-24.12 Nov 15, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci feature request New feature or request Needs build-infra Requires input from the build infrastructure team non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants