Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move libcudf reduction google-benchmarks to nvbench #16564

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Aug 14, 2024

Description

Reworks the reduction benchmarks currently coded with google-bench to use nvbench instead.
This removes the need to support row_bit_count for dictionary column types.
#16121

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 14, 2024
@davidwendt davidwendt self-assigned this Aug 14, 2024
@github-actions github-actions bot added the CMake CMake build issue label Aug 14, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 19, 2024
@davidwendt davidwendt marked this pull request as ready for review August 19, 2024 13:17
@davidwendt davidwendt requested a review from a team as a code owner August 19, 2024 13:17
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8ab553c into rapidsai:branch-24.10 Aug 21, 2024
80 checks passed
@davidwendt davidwendt deleted the reduction-nvbench branch August 21, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants