Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dictionary support to cudf::row_bit_count #16534

Closed
wants to merge 3 commits into from

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Aug 12, 2024

Description

Adds support for dictionary column types in the cudf::row_bit_count() API. The indices can be any integer type and the keys can be any non-dictionary comparable type. The indices are computed separately and the keys are flattened before computed.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 12, 2024
@davidwendt davidwendt self-assigned this Aug 12, 2024
@davidwendt
Copy link
Contributor Author

Closing this since #16564 made the need for this obsolete.

@davidwendt davidwendt closed this Aug 23, 2024
@davidwendt davidwendt deleted the dict-bit-count branch August 23, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant