Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy JSON reader and concurrent_unordered_map.cuh. #15813

Merged
merged 3 commits into from
May 23, 2024
Merged

Remove legacy JSON reader and concurrent_unordered_map.cuh. #15813

merged 3 commits into from
May 23, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 22, 2024

Description

This completes the final two steps and closes #15537. Also addresses one step of #12261.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice changed the base branch from branch-24.06 to branch-24.08 May 22, 2024 06:07
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue conda Java Affects Java cuDF API. labels May 22, 2024
This was referenced May 22, 2024
Open
Closed
@github-actions github-actions bot removed conda Java Affects Java cuDF API. labels May 22, 2024
@bdice bdice added breaking Breaking change improvement Improvement / enhancement to an existing function labels May 22, 2024
@bdice bdice marked this pull request as ready for review May 22, 2024 18:28
@bdice bdice requested review from a team as code owners May 22, 2024 18:28
@bdice bdice requested review from wence-, isVoid, harrism and shrshi May 22, 2024 18:28
KyleFromNVIDIA
KyleFromNVIDIA approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved trivial CMake changes

shrshi
shrshi approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@shrshi shrshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

mroeschke
mroeschke approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python changes look good

@bdice
Copy link
Contributor Author

bdice commented May 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9d8e43e into rapidsai:branch-24.08 May 23, 2024
70 checks passed
@bdice bdice mentioned this pull request Jul 2, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Jul 2, 2024
@vuule
Remove the (unused) implementation of host_parse_nested_json (#16135)
04e3aa9 
Follow-up for #15537 and #15813 to remove some missed code.

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - David Wendt (https://github.com/davidwendt)

URL: #16135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@davidwendt davidwendt davidwendt approved these changes

@mroeschke mroeschke mroeschke approved these changes

@shrshi shrshi shrshi approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
breaking Breaking change CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Remove legacy JSON reader
5 participants
@bdice @shrshi @mroeschke @davidwendt @KyleFromNVIDIA