Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Description tag in site and group configs #70

Merged
merged 6 commits into from
Jul 17, 2014
Merged

Add support for new Description tag in site and group configs #70

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9e8997
add support for new <Description> tag in AssetGroupConfig
gschneider-r7 Jul 7, 2014
31dece2
add support for new <Description> tag in SiteConfig
gschneider-r7 Jul 7, 2014
49ab22c
use conditional to match original behavior on description
gschneider-r7 Jul 7, 2014
fbe2422
get the description text and not the element!
gschneider-r7 Jul 8, 2014
14ef506
refactor group to_xml to use as_xml like sites
gschneider-r7 Jul 10, 2014
71c6421
Make sure that we don't use a nil description in site or group saves
gschneider-r7 Jul 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make sure that we don't use a nil description in site or group saves
  • Loading branch information
@gschneider-r7
gschneider-r7 committed Jul 11, 2014
commit 71c642161f25c23f8c31bff1e0125e14fe3f2f0d
2 changes: 1 addition & 1 deletion lib/nexpose/group.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def as_xml
xml.attributes['name'] = @name
xml.attributes['description'] = @description

unless @description.empty?
if @description && !@description.empty?
elem = REXML::Element.new('Description')
elem.add_text(@description)
xml.add_element(elem)
Expand Down
2 changes: 1 addition & 1 deletion lib/nexpose/site.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ def as_xml
xml.attributes['riskfactor'] = @risk_factor
xml.attributes['isDynamic'] == '1' if dynamic?

unless @description.empty?
if @description && !@description.empty?
elem = REXML::Element.new('Description')
elem.add_text(@description)
xml.add_element(elem)
Expand Down