Add support for new Description tag in site and group configs #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,6 +99,7 @@ def to_xml | |||
| xml = %(<AssetGroup id="#{@id}" name="#{replace_entities(@name)}") | |||
| xml << %( description="#{replace_entities(@description)}") if @description | |||
| xml << '>' | |||
| xml << "<Description>#{replace_entities(@description)}</Description>" if @description | |||
There was a problem hiding this comment.
Should fix this XML generate (for the whole class) from String manipulation to REXML, adding a as_xml method, then the to_xml just calls as_xml.to_s.
There was a problem hiding this comment.
Good idea. I've added a new commit with these changes.
mdaines-r7
added a commit
that referenced
this pull request
Jul 17, 2014
Add support for new Description tag in site and group configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support site and group descriptions with newline characters in an upcoming Nexpose release. This change should be backwards-compatible, though, and can probably be merged in at any time. The
<Description>tag is ignored by current Nexpose versions and is optional for future versions.