add new module: Pcap OT/IOT analyzer #19481
Open
+218
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+37
to
+50
| unless File.exist?(datastore['FILE_PCAP']) && File.extname(datastore['FILE_PCAP']) == '.pcap' | ||
| print_error("Invalid or non-existent PCAP file: #{datastore['FILE_PCAP']}") | ||
| return | ||
| end | ||
|
|
||
| unless File.exist?(datastore['FILE_PORT']) && File.extname(datastore['FILE_PORT']) == '.txt' | ||
| print_error("Invalid or non-existent port file: #{datastore['FILE_PORT']}") | ||
| return | ||
| end | ||
|
|
||
| if File.exist?(datastore['FILE_OUT']) | ||
| print_error("Output file already exists: #{datastore['FILE_OUT']}") | ||
| return | ||
| end |
There was a problem hiding this comment.
Instead of print_error for each of these you should use fail_with(Failure::BadConfig, ...
| pkt = PacketFu::Packet.parse(packet) | ||
| next unless pkt.is_ip? | ||
|
|
||
| timestamp = Time.at(packet.timestamp.to_f).strftime('%y/%m/%d - %H:%M:%S') |
There was a problem hiding this comment.
Can we switch this to the ISO8601 format please? it's YYYY-MM-DDTHH:MM:SS IIRC.
Suggested change
| timestamp = Time.at(packet.timestamp.to_f).strftime('%y/%m/%d - %H:%M:%S') | |
| timestamp = Time.at(packet.timestamp.to_f).strftime() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us what this change does. If you're fixing a bug, please mention
the github issue number.
Please ensure you are submitting from a unique branch in your repository to master in Rapid7's.
Verification
List the steps needed to make sure this thing works
msfconsoleuse exploit/windows/smb/ms08_067_netapiIf you are opening a PR for a new module that exploits a specific piece of hardware or requires a complex or hard-to-find testing environment, we recommend that you send us a demo of your module executing correctly. Seeing your module in action will help us review your PR faster!
Specific Hardware Examples:
Complex Software Examples:
We will also accept demonstrations of successful module execution even if your module doesn't meet the above conditions. It's not a necessity, but it may help us land your module faster!
Demonstration of successful module execution can take the form of a packet capture (pcap) or a screen recording. You can send pcaps and recordings to msfdev@metasploit.com. Please include a CVE number in the subject header (if applicable), and a link to your PR in the email body.
If you wish to sanitize your pcap, please see the wiki.