Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getAllKeys Method to SyncStorage #5

Merged
merged 11 commits into from
Oct 29, 2018
Merged

Add getAllKeys Method to SyncStorage #5

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d217452
Add getAllKeys method
iamsoorena Sep 3, 2018
652a6d7
Add update method
iamsoorena Sep 3, 2018
d6f57ea
Add push method
iamsoorena Sep 3, 2018
90ef7c8
Add update to readme
iamsoorena Sep 3, 2018
83ae4e3
Fix small grammatical problem in error message of update method
iamsoorena Sep 3, 2018
98b0ae3
Add test for push update and getAllKeys methods
iamsoorena Sep 3, 2018
725c715
Add test for push error for non Array value
iamsoorena Sep 3, 2018
3ea81c6
Refactoring
iamsoorena Sep 3, 2018
2cd7e87
Fix flow for second argument in handleError
iamsoorena Sep 3, 2018
2890ec0
Remove push and update functions
iamsoorena Oct 26, 2018
895ccf2
Update readme, fixing small issue with tests.
iamsoorena Oct 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add update method
  • Loading branch information
@iamsoorena
iamsoorena committed Sep 3, 2018
commit 652a6d79609c84830bd40aaf834a0f609d9a4bc9
11 changes: 11 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,17 @@ class SyncStorage {
getAllKeys(): Array<*> {
return Array.from(this.data.keys());
}

update(key: KeyType, value: any): Promise<*> {
if (!key) return handleError('update', 'a key');
const item = this.get(key);
if (item !== undefined) {
return this.set(key, value);
}
const message = 'You can not update a key that has not been set yet.';
console.warn(message); // eslint-disable-line no-console
return Promise.reject(message);
}
}

const syncStorage = new SyncStorage();
Expand Down