Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getAllKeys Method to SyncStorage #5

Merged
merged 11 commits into from
Oct 29, 2018
Merged

Add getAllKeys Method to SyncStorage #5

merged 11 commits into from
Oct 29, 2018

Conversation

iamsoorena
Copy link
Contributor

I thought since I use these methods All the time, It would be a good idea to suggest adding them to this library.

@iamsoorena
Copy link
Contributor Author

I'm currently working on adding tests and updating readme. In the meantime please give me feedback if you think adding these methods is a good idea or not.

@iamsoorena
Copy link
Contributor Author

Also I can't make CI to run successfully 😂

@raphaelpor
Copy link
Owner

Hello @iamsoorena!

Thanks for your PR. I'll help you with this error. 😉

@olfek
Copy link
Contributor

olfek commented Oct 25, 2018

@raphaelpor @iamsoorena I disagree with adding the push and update functions because the set function already does the job of both. I do agree with having a getAllKeys function though.

@raphaelpor
Copy link
Owner

@olfek I agree with you.

@iamsoorena Could you please remove the push and update functions? Let's keep this PR only for getAllKeys. 😉

@iamsoorena
Copy link
Contributor Author

@raphaelpor It's done.

raphaelpor
raphaelpor requested changes Oct 27, 2018
View reviewed changes
README.md Outdated
@@ -93,3 +93,27 @@ SyncStorage.remove('foo')
console.log(error);
});
```

#### update(key: _string_, value: _Any type_)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would to be getAllKeys, right? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I forgot that.

@iamsoorena iamsoorena changed the title Add push, getAllKeys and update Method to SyncStorage Add getAllKeys Method to SyncStorage Oct 27, 2018
@raphaelpor raphaelpor merged commit 25ef251 into raphaelpor:master Oct 29, 2018
@raphaelpor
Copy link
Owner

Thanks, guys! ❤️
@iamsoorena @olfek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelpor raphaelpor raphaelpor approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamsoorena @raphaelpor @olfek