Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yarn in CI #180

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Use yarn in CI #180

merged 1 commit into from
Nov 2, 2016

Conversation

troyt-42
Copy link
Contributor

@troyt-42 troyt-42 commented Nov 2, 2016

@smithad15
Copy link
Contributor

Should we also add a yarn.lock file to the repo?

@troyt-42
Copy link
Contributor Author

troyt-42 commented Nov 2, 2016

@smithad15 since we do not force the use of yarn in developer's own environment, we should not include the yarn.lock?

@winkerVSbecks
Copy link
Contributor

:shipit:

@troyt-42 troyt-42 merged commit 6e71ec0 into rangle:master Nov 2, 2016
@SethDavenport
Copy link
Contributor

@watrool , @smithad15 is right. We should check in the yarn.lock. It's what allows yarn to use a consistent set of transitive dependency versions.

A user can still use npm if they want, but it will ignore the lockfile and he will not benefit from the shrinkwrapping it provides. But it still needs to be checked in.

@winkerVSbecks
Copy link
Contributor

@SethDavenport do we no longer need rm -rf node_modules because of yarn?

@troyt-42 troyt-42 mentioned this pull request Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants