Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn on CI? #189

Open
SethDavenport opened this issue Oct 26, 2016 · 6 comments
Open

yarn on CI? #189

SethDavenport opened this issue Oct 26, 2016 · 6 comments

Comments

@SethDavenport
Copy link
Contributor

SethDavenport commented Oct 26, 2016

I'm a big fan of yarn: https://yarnpkg.com/

I don't think we should require people to use it, but it might be worth getting it to work on CI for reliability (yarn.lock) and build speed.

Should just be a matter of updating the circle.yaml as follows:

machine:
  node:
    version: 6
dependencies:
  pre:
    - npm install -g yarn@0.16.1
  override:
    - yarn install
test:
  pre:
    - yarn run clean
    - yarn run test:lint
  override:
    - yarn test
general:
  artifacts:
    - "./coverage"

And also doing yarn install locally and checking in the yarn.lock file.

@SethDavenport
Copy link
Contributor Author

Yes, we want it :)

@SethDavenport
Copy link
Contributor Author

We won't force people to use it; things will still work using npm. But CI will use yarn.

@SethDavenport
Copy link
Contributor Author

Added to api-koa-starter. Also boosted the node requirement to v6 since it's LTS now.

@SethDavenport
Copy link
Contributor Author

  • create react app script: creates a yarnified circle.yml
  • angular2-starter: yarnified circle.yml
  • api-koa-starter: yarnified circle.yml

@bennett000
Copy link

@SethDavenport
Copy link
Contributor Author

You may need to switch your circle ci settings to use ubuntu 14.04 containers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants