Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set serial console baudrate to 115200 #550

Closed
wants to merge 2 commits into from

Conversation

kkaempf
Copy link
Contributor

@kkaempf kkaempf commented Dec 1, 2022

This is the standard baudrate on Raspberry Pi.

Signed-off-by: Klaus Kämpf kkaempf@suse.de

This is the standard baudrate on Raspberry Pi.

Signed-off-by: Klaus Kämpf <kkaempf@suse.de>
@ldevulder
Copy link
Contributor

ldevulder commented Dec 2, 2022

Just small comments:

  • without any value it should be auto detected
  • also Serial-Over-Lan on IPMI is by default 19200, so this might have an impact on some hardware.

@kkaempf
Copy link
Contributor Author

kkaempf commented Dec 2, 2022

Just small comments:

* without any value it should be auto detected

Doesn't work on RPi 😞

* also Serial-Over-Lan on IPMI is be default 19200, so this might have an impact on some hardware.

Hmm, rancher/elemental-toolkit#1773 😉

Maybe restrict this change to aarch64 for now ? 🤔

Copy link
Contributor

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont really like this. Is RPI a supported platform? We are potentially breaking all the rest of the stuff to cater to a small rpi niche :/

Cant this be fixed in a different way? is the problem on raw image generation? Maybe we can add some overrides or flags to the raw image generation instead, leave them by default and allow to override it somehow=

How has this appear now? cOS has been tested a lot on RPI IIRC with no issues with this?

@kkaempf
Copy link
Contributor Author

kkaempf commented Dec 12, 2022

dont really like this. Is RPI a supported platform?

Not supported, but sufficiently easy to use with Elemental. It also makes a good demo (and we have plenty of requests for it) 😉

We are potentially breaking all the rest of the stuff to cater to a small rpi niche :/

That's bad, I agree.

Cant this be fixed in a different way? is the problem on raw image generation? Maybe we can add some overrides or flags to the raw image generation instead, leave them by default and allow to override it somehow=

Yes, that would be awesome. Some kind of platform flag/parameter ...

How has this appear now? cOS has been tested a lot on RPI IIRC with no issues with this?

Because it's not an issue with cOS/Elemental as such but when testing/debugging. One usually doesn't have a serial console attached. But when you have, you want the Kernel to use the same baudrate like the firmware/bootloader.

@kkaempf
Copy link
Contributor Author

kkaempf commented Jun 29, 2023

Closing this PR to find a more flexible approach

@kkaempf kkaempf closed this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants