Add cmdline argument to ISO #453
Conversation
Add the `rd.live.overlay.overlayfs=1` cmdline argument since it seems to be needed to boot when building a tumbleweed ISO. Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main rancher/elemental-cli#453 +/- ##
==========================================
- Coverage 76.83% 76.75% -0.08%
==========================================
Files 61 61
Lines 6307 6307
==========================================
- Hits 4846 4841 -5
- Misses 1134 1139 +5
Partials 327 327
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Would be nice to be able to send in or override the cmdline params as well.. food for thought! |
There was a problem hiding this comment.
In fact, as you realized the ideal would be making all this configurable. I'd say this would be nice to configure it in two different parameters: predifined values and extra values. Predefined ones would be a parameter that defaults to the current kernel arguments. Extra values would default to an empty set. So from a user perspective you could append or overwrite the kernel arguments.
I'd like to bring a similar concept for the install and reset commands.
| @@ -63,7 +63,7 @@ const ( | |||
|
|
|||
| menuentry "%s" --class os --unrestricted { | |||
| echo Loading kernel... | |||
| $linux ($root)` + constants.ISOKernelPath + ` cdroot root=live:CDLABEL=%s rd.live.dir=/ rd.live.squashimg=rootfs.squashfs console=tty1 console=ttyS0 rd.cos.disable cos.setup=` + constants.ISOCloudInitPath + ` | |||
| $linux ($root)` + constants.ISOKernelPath + ` cdroot root=live:CDLABEL=%s rd.live.dir=/ rd.live.squashimg=rootfs.squashfs rd.live.overlay.overlayfs=1 console=tty1 console=ttyS0 rd.cos.disable cos.setup=` + constants.ISOCloudInitPath + ` | |||
There was a problem hiding this comment.
I wonder which is the TW alternative to overlayfs 🤔
Yep, that sounds great! I will put up an issue for this instead. As you said we should also see how this plays out with install/upgrade 👍 |
|
👍 on making these arguments better configurable - see also rancher/elemental#550 |
|
Oh, there's also rancher/elemental-toolkit#1773 |
Add the
rd.live.overlay.overlayfs=1cmdline argument since it seems to be needed to boot when building a tumbleweed ISO.