Add e2e tests for create rke1 custom cluster #9058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
force-pushed
the
e2e-create-rke1
branch
from
ce9ccfc
to
afff4f3
Compare
mantis-toboggan-md
requested changes
Jun 8, 2023
richard-cox
force-pushed
the
e2e-create-rke1
branch
2 times, most recently
from
c024ae5
to
c2460e9
Compare
|
The code looks fine aside from linting errors, but I think e2e ci tests wont pass until a new v2.7-head rancher/rancher image is available. Since we're running our e2e rancher docker instance with |
|
Hadn't managed to get around to debugging this, good find! We need to bring in the latest rancher/ui build and serve it up as per the new way we build and serve the dashboard. I've created #9217 to cover this. Otherwise the last RC build will be used |
- also updated lots of ~/ @/
richard-cox
force-pushed
the
e2e-create-rke1
branch
from
b50a4b5
to
dce0a11
Compare
mantis-toboggan-md
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8785
Occurred changes and/or fixed issues
Technical notes summary