Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation: RKE1 provisioning member roles' "custom role" modal checkbox don't work correctly #8785

Closed
gaktive opened this issue May 3, 2023 · 2 comments · Fixed by #9058
Assignees
Labels
kind/tech-debt Technical debt QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@gaktive
Copy link
Member

gaktive commented May 3, 2023

Based on the work done in #8621, let's write an automated test to verify that when we create or edit an RKE1 cluster and the membership section allows users to define custom roles, clicking the label of each checkbox actually selects it.

Previous, selections are only saved when clicking the box itself.

@Shavindra may be able to help here.

To reproduce:

  • Navigate to Cluster Management > Cluster > Edit Cluster > Cluster Roles
  • Select user and Custom role
  • Click on the labels of the roles. It should select the different roles
  • When click on save it should create all the roles
  • This can be verified by navigating to Cluster Explorer > Cluster > Cluster & Project members and sorting the list by age to view recently created roles.
@gaktive gaktive added [zube]: Backlog kind/tech-debt Technical debt QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels May 3, 2023
@gaktive gaktive added this to the v2.6.patch2 milestone May 3, 2023
@gaktive gaktive modified the milestones: v2.6.patch2, v2.7.next2 May 10, 2023
@richard-cox
Copy link
Member

We can only test this via e2e on a created RKE1 cluster (i don't think we need credentials to get to the page like we do with RKE2). It's also ember side where we don't have unit test support

@richard-cox
Copy link
Member

Depends on rancher/ui#5035. This contains functional changes that shouldn't merge until 2.7q2 is out. I'll bump this out to 2.7q3 and do some limited manual testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech-debt Technical debt QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants