-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving some issues around rendering pagination loading on resource list pages #12884
Resolving some issues around rendering pagination loading on resource list pages #12884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little bit nervous getting this one in before the two big PRs, can we wait for them or base this on on top of the later?
Yeah, I'm in favor of waiting until after they're merged. |
5ece7f8
to
5c69e4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some good fixes in here, just a couple of inline comments.
Validated / Tested
- SSP Enabled
- initial nav to page
- refresh button on page
- changing sort / filer
- Generic / Custom lists
- SSP Disabled
- no perf settings
- manual refresh
- incremental loading
5c69e4b
to
728bc64
Compare
Summary
It wasn't readily apparent what the expected behavior was around things like alt-loading and the manual refresh so I did what made sense to me. See the video to see if it's what we want or if adjustments need to be made.
fixes #12748
Occurred changes and/or fixed issues
We no longer flicker the no-rows messaging when first loading one of the server-side pagination pages.
Areas or cases that should be tested
SSP and non-SSP resource list pages.
I think that this should be manually tested, it seems a little difficult to test given the nature of network latency and debouncing we have.
Screenshot/Video
The behavior seen in this video has changed some since the latest rebase. https://github.com/rancher/dashboard/pull/12884/files#diff-16199a1483a9651b7f40bfcb61ed890469ea35d889aee82b0f50b95d2ed2057eR506-R510 Causes the refresh button to no longer trigger the altLoading overlay/opacity. This appears to be intended but maybe we'll want to update it because the lack of feedback makes me think nothing is happening.
list-loading.mp4
Checklist