Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving some issues around rendering pagination loading on resource list pages #12884

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

codyrancher
Copy link
Contributor

@codyrancher codyrancher commented Dec 13, 2024

Summary

It wasn't readily apparent what the expected behavior was around things like alt-loading and the manual refresh so I did what made sense to me. See the video to see if it's what we want or if adjustments need to be made.

fixes #12748

Occurred changes and/or fixed issues

We no longer flicker the no-rows messaging when first loading one of the server-side pagination pages.

Areas or cases that should be tested

SSP and non-SSP resource list pages.

I think that this should be manually tested, it seems a little difficult to test given the nature of network latency and debouncing we have.

Screenshot/Video

The behavior seen in this video has changed some since the latest rebase. https://github.com/rancher/dashboard/pull/12884/files#diff-16199a1483a9651b7f40bfcb61ed890469ea35d889aee82b0f50b95d2ed2057eR506-R510 Causes the refresh button to no longer trigger the altLoading overlay/opacity. This appears to be intended but maybe we'll want to update it because the lack of feedback makes me think nothing is happening.

list-loading.mp4

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@codyrancher codyrancher added this to the v2.11.0 milestone Dec 13, 2024
@codyrancher codyrancher changed the title Resolving some issues around rendering pagination loading on resource… Resolving some issues around rendering pagination loading on resource list pages Dec 13, 2024
@codyrancher codyrancher marked this pull request as ready for review December 13, 2024 05:09
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little bit nervous getting this one in before the two big PRs, can we wait for them or base this on on top of the later?

@codyrancher
Copy link
Contributor Author

Little bit nervous getting this one in before the two big PRs, can we wait for them or base this on on top of the later?

Yeah, I'm in favor of waiting until after they're merged.

@codyrancher codyrancher marked this pull request as draft December 17, 2024 19:02
@codyrancher codyrancher force-pushed the ssp-list-loading-render branch 2 times, most recently from 5ece7f8 to 5c69e4b Compare January 7, 2025 22:20
@codyrancher codyrancher marked this pull request as ready for review January 8, 2025 00:28
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some good fixes in here, just a couple of inline comments.

Validated / Tested

  • SSP Enabled
    • initial nav to page
    • refresh button on page
    • changing sort / filer
    • Generic / Custom lists
  • SSP Disabled
    • no perf settings
    • manual refresh
    • incremental loading

shell/components/ResourceList/index.vue Show resolved Hide resolved
shell/components/SortableTable/index.vue Outdated Show resolved Hide resolved
@codyrancher codyrancher force-pushed the ssp-list-loading-render branch from 5c69e4b to 728bc64 Compare January 8, 2025 23:29
@codyrancher codyrancher merged commit b4f3939 into rancher:master Jan 9, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching between server-side paginated lists incorrectly briefly shows 'no row's message before rows shown
2 participants