Perform flags modification only in ConfigMap or install #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
patch-flags-on-install
branch
from
f3b6d98 to
345ed49
Compare
anmazzotti
reviewed
Apr 14, 2025
| .collect()); | ||
| let env_map = settings.fleet.extra_env.get_or_insert_default(); | ||
|
|
||
| match env_map |
anmazzotti
reviewed
Apr 14, 2025
| self.status | ||
| .get_or_insert_default() | ||
| .conditions | ||
| .push(Condition { |
There was a problem hiding this comment.
Nice one, this was missing.
anmazzotti
approved these changes
Apr 14, 2025
Danil-Grigorev
moved this from In Progress (8 max)
to PR to be reviewed
in CAPI / Turtles
github-project-automation
bot
moved this from PR to be reviewed
to Done
in CAPI / Turtles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove direct helm chart modifications beyond chart
installconfig, and merge experimental flags configuration with fleet chart installation.Simplify conditions handling by using
get_or_insert_default.Flags configuration inside
ConfigMapis refactored to ensure that code works on a valid structure, despite the custom merge of json and yaml data inside it due to downstream expectations. We also need to set condition on the resource, to display the state of the reconcile.Fixes #250