Tests: update the included composer.phar from v 2.2.2 to 2.2.18
#237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the default PHP version on `ubuntu-latest` has been updated to PHP 8.1.11, which means that the `expect` tests running with the included `composer.phar` will error out on a fatal `PHP Fatal error: Uncaught TypeError: array_merge(): Argument #1 must be of type array, bool given in phar:///home/runner/work/composer-install/composer-install/tests/fixtures/composer.phar/src/Composer/Config.php:191` error. Updating the included `composer.phar` to a more recent version fixes this. Alternatively, the file could be removed and downloaded (or updated) on the fly from within CI ? Refs: * https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md
|
Note: the tests will still fail on #236, but this is step 1 in fixing the current CI failure. |
7 tasks
|
On one hand, it's annoying to have to update the expected version every time |
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like the default PHP version on
ubuntu-latesthas been updated to PHP 8.1.11, which means that theexpecttests running with the includedcomposer.pharwill error out on a fatalPHP Fatal error: Uncaught TypeError: array_merge(): Argument #1 must be of type array, bool given in phar:///home/runner/work/composer-install/composer-install/tests/fixtures/composer.phar/src/Composer/Config.php:191error.Updating the included
composer.pharto a more recent version fixes this.Alternatively, the file could be removed and downloaded (or updated) on the fly from within CI ?
Refs:
PR checklist