-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix finding composer cache dir #233
Conversation
@ramsey Could you have a look, please? |
@ramsey Fixed conflict |
@ramsey Seems the v1 fail already happens in upstream branch, so this might be good to go? |
@TamasSzigeti Please update your branch with the latest upstream changes. Thanks! |
@ramsey Done |
@ramsey Adjusted the test for the changed github output |
@ramsey Is there anything yet to be done here? |
@TamasSzigeti Are you able to fix the test failures? |
@ramsey |
Has there been any further progress on this? I can report that caching does not work correctly when using a "working-directory" input. |
Meh, I had just opened a duplicate in #247 before I found this 🤦♂️ |
Related issue: #246 |
@mxr576 I totally forgot about this PR, maybe you could take it over, fix tests? |
I cannot make any promises, tests were not executed on my PR because I am a first time contributor and I do not see failures due to: "The logs for this run have expired and are no longer available." Rebasing/retriggering the build could be useful |
@mxr576 If you want to reopen your PR, I can click the button to allow the tests to run. |
Thanks, reopened |
@ramsey Sorry for taking this long, I fixed the tests, should be all green now. |
Same here... ;S thx!!! \o/ |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v2 #233 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 7 7
Lines 203 203
=======================================
Hits 171 171
Misses 32 32
|
Thank you! |
Description
Fix missing working dir when getting composer cache dir config
Bumping included composer.phar version to fix CI error – to the minimum that has this fix
Motivation and context
Fixes #225
How has this been tested?
Tested by manually running composer_paths.sh in a directory where there is no composer.lock
Current tests do not fail because there is another composer.lock in tests dir.
Added another test case, hope it works (:
Types of changes
PR checklist