Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved hardcoded text titles to _config.yml #10

Merged
merged 5 commits into from
Jan 31, 2018
Merged

Moved hardcoded text titles to _config.yml #10

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef1918b
Moved hardcoded text titles to _config.yml
samcolby Dec 8, 2017
82ab2ba
Moved about text into a new about object in _config.yml
samcolby Dec 9, 2017
54bdc15
Update index.html
ramswaroop Jan 31, 2018
1ed703a
Update _config.yml
ramswaroop Jan 31, 2018
52541af
Update _config.yml
ramswaroop Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Moved hardcoded text titles to _config.yml
  • Loading branch information
@samcolby
samcolby committed Dec 8, 2017
commit ef1918bfbf32356c248c937459d215779645c9fa
3 changes: 3 additions & 0 deletions _config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ google_analytics: "UA-46465113-2"
# UI configs
title: "Photography by Ram Patra"
subtitle: "See the world through my eyes!"
html_title: "Photography"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that title and subtitle aren't used anywhere so we can reuse them.

html_subtitle: "by Ram Patra"
author: "Ram Patra"
about_header: "Hey there, my name is Ram"
Copy link
Owner

@rampatra rampatra Dec 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have all these 3 as sub-configs under about like:

about:
 header:
 bio:
 publicise:

bio: "I am a developer and a tech aficionado from India. Love making teeny tiny apps solving tiny problems in life and now learning photography."
publicise: "Want a website like this for yourself for free? Just <a href=\"https://github.com/ramswaroop/photography\">fork me on github</a> ;)"
web_design: "AJ"
Expand Down
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<!-- Header -->
<header id="header">
<h1><a href="index.html"><strong>Photography</strong> by Ram Patra</a></h1>
<h1><a href="index.html"><strong>{{ site.html_title }}</strong> {{ site.html_subtitle }}</a></h1>
<nav>
<ul>
<li><a href="#footer" class="icon fa-info-circle">About</a></li>
Expand All @@ -34,7 +34,7 @@ <h1><a href="index.html"><strong>Photography</strong> by Ram Patra</a></h1>
<div class="inner split">
<div>
<section>
<h2>Hey there, my name is Ram</h2>
<h2>{{ site.about_header }}</h2>
<p>{{ site.bio }}</p>
<p>{{ site.publicise }}</p>
</section>
Expand Down