Moved hardcoded text titles to _config.yml #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rampatra
reviewed
Dec 9, 2017
_config.yml
Outdated
| @@ -7,7 +7,10 @@ google_analytics: "UA-46465113-2" | |||
| # UI configs | |||
| title: "Photography by Ram Patra" | |||
| subtitle: "See the world through my eyes!" | |||
| html_title: "Photography" | |||
There was a problem hiding this comment.
I see that title and subtitle aren't used anywhere so we can reuse them.
rampatra
reviewed
Dec 9, 2017
_config.yml
Outdated
| author: "Ram Patra" | ||
| about_header: "Hey there, my name is Ram" |
There was a problem hiding this comment.
We can have all these 3 as sub-configs under about like:
about:
header:
bio:
publicise:
|
Yes, happy to change the names of these title is used in header.html Was subtitle was originally intended to be used for the meta description tag? No issues with the other change, I'll take a look at it. Sam |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up new html_title, html_subtitle and about_header config values to remove a bit more hardcoding.