Skip to content

Fix for #707 #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rafaelfranca merged 2 commits into from
Jun 8, 2021
Merged

Fix for #707 #708

rafaelfranca merged 2 commits into from
Jun 8, 2021

Conversation

@scambra
Copy link
Contributor

@scambra scambra commented Jan 10, 2020

Try to replace text but skip overwritting file with pretend option

@scambra
Fix for rails#707
003d113 
Try to replace text but skip overwritting file with pretend option
@scambra
test inject_into_file with pretend
baf7e46
dorner
dorner approved these changes Jun 3, 2021
View reviewed changes
Copy link

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @rafaelfranca

@rafaelfranca rafaelfranca merged commit efe79b5 into rails:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dorner dorner dorner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scambra @dorner @rafaelfranca