Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inject_into_file with pretend reports file unchanged #707

Closed
scambra opened this issue Jan 10, 2020 · 3 comments
Closed

inject_into_file with pretend reports file unchanged #707

scambra opened this issue Jan 10, 2020 · 3 comments

Comments

@scambra
Copy link
Contributor

scambra commented Jan 10, 2020

Before this commit 25dc317 inject_into_file with pretend option was printing inject line, but now it complains about file didn't change.

The best way it would try to replace and return success, without writing file
scambra added a commit to scambra/thor that referenced this issue Jan 10, 2020
@scambra
Fix for rails#707
003d113 
Try to replace text but skip overwritting file with pretend option
@dorner
Copy link

dorner commented Jun 1, 2021

@scambra not sure if you're still interested in this - it looks good to me but there should be a spec to cover this behavior.

@scambra
Copy link
Contributor Author

scambra commented Jun 1, 2021

yes, I'm still interested, I will look into specs whenever I can

@scambra
Copy link
Contributor Author

scambra commented Jun 3, 2021

@dorner I have added a spec for inject_into_file with pretend

rafaelfranca added a commit that referenced this issue Jun 8, 2021
@rafaelfranca
Merge pull request #708 from scambra/patch-1
efe79b5 
Fix for #707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scambra @rafaelfranca @dorner