Skip to content

Rails 6.1: Raise ActiveRecord::ConnectionNotEstablished on calls to execute with a disconnected connection. #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 28, 2021
Merged

Rails 6.1: Raise ActiveRecord::ConnectionNotEstablished on calls to execute with a disconnected connection. #903

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5228be2
raise ActiveRecord::ConnectionNotEstablished instead of ActiveRecord:…
mgrunberg Apr 21, 2021
5f1f8a3
add test of other calls to connection.execute that should fail
mgrunberg Apr 21, 2021
e4eb203
add changelog item
mgrunberg Apr 21, 2021
9f18dd9
Refactor
Apr 21, 2021
a97115e
Merge pull request #1 from aidanharan/raise-connection-not-establishe…
mgrunberg Apr 21, 2021
9ddca72
fix typo
mgrunberg Apr 23, 2021
6861763
check connection active to prevent usage of dead/closed connection
mgrunberg Apr 23, 2021
21a1962
raise TinyTds::Error and translate it. 'active?' method is rescuing j…
mgrunberg Apr 23, 2021
91701a6
Revert "check connection active to prevent usage of dead/closed conne…
mgrunberg Apr 27, 2021
470c569
check TinyTds FalseClass response in execute_procedure and raw_connec…
mgrunberg Apr 27, 2021
6b73a4e
raise ConnectionNotEstabilished when TinyTDS returns false
mgrunberg Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "check connection active to prevent usage of dead/closed conne… 
…ction"

This reverts commit 6861763.
  • Loading branch information
@mgrunberg
mgrunberg committed Apr 27, 2021
commit 91701a633c1361cfd858cc99c8f73c88b769f4d9
2 changes: 1 addition & 1 deletion lib/active_record/connection_adapters/sqlserver/database_statements.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ def finish_statement_handle(handle)
end

def ensure_established_connection!
raise TinyTds::Error, 'SQL Server client is not connected' if @connection.nil? || !@connection.active?
raise TinyTds::Error, 'SQL Server client is not connected' unless @connection

yield
end
Expand Down