Skip to content

Rails 6.1: Raise ActiveRecord::ConnectionNotEstablished on calls to execute with a disconnected connection. #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test of other calls to connection.execute that should fail
  • Loading branch information
mgrunberg committed Apr 21, 2021
commit 5f1f8a33757a8bf8bb7aae284cffaddc3cd2baff
39 changes: 39 additions & 0 deletions test/cases/disconnected_test_sqlserver.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# frozen_string_literal: true

require "cases/helper_sqlserver"

class TestDisconnectedAdapter < ActiveRecord::TestCase
self.use_transactional_tests = false

def setup
@connection = ActiveRecord::Base.connection
end

teardown do
return if in_memory_db?
db_config = ActiveRecord::Base.connection_db_config
ActiveRecord::Base.establish_connection(db_config)
end

test "can't execute procuderes while disconnected" do
@connection.execute_procedure :sp_tables, "sst_datatypes"
@connection.disconnect!
assert_raises(ActiveRecord::ConnectionNotEstablished) do
@connection.execute_procedure :sp_tables, "sst_datatypes"
end
end

test "can't execute query while disconnected" do
sql = "SELECT count(*) from products WHERE id IN(@0, @1)"
binds = [
ActiveRecord::Relation::QueryAttribute.new("id", 2, ActiveRecord::Type::BigInteger.new),
ActiveRecord::Relation::QueryAttribute.new("id", 2, ActiveRecord::Type::BigInteger.new)
]

@connection.exec_query sql, "TEST", binds
@connection.disconnect!
assert_raises(ActiveRecord::ConnectionNotEstablished) do
@connection.exec_query sql, "TEST", binds
end
end
end