Remove webargs #6246
Merged
Remove webargs #6246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One function was dead code, in the other case we could use marshmallow instead of the webargs function, which is more consistent with the rest of the code.
I could not get it working with recent webargs versions and it was intransparent what it did in detail. The two replacement functions are small and straightforward. The new version also makes it clear that the parameters in the URL path are not being validated by the schemas. That was already the case before this commit, but it was really hard to spot.
Since we already use marshmallow, webargs does not provide much benefit.
We are using marshmallow3, so `strict` is the default and the return values work without explicitly casting them to dicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to the latest webargs version breaks multiple things. Since we don't use much functionality from webargs, this is a good opportunity to reduce the number of dependencies.